[Hyper-v platform] Enabling more testcases to run on Hyper-V platform #3623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiliDeng
reviewed
Feb 4, 2025
microsoft/testsuites/core/dhcp.py
Outdated
| @@ -33,7 +33,7 @@ class Dhcp(TestSuite): | |||
|
|
|||
| """, | |||
| priority=1, | |||
| requirement=simple_requirement(supported_platform_type=[AZURE, READY]), | |||
| requirement=simple_requirement(supported_platform_type=[AZURE, READY, HYPERV]), | |||
There was a problem hiding this comment.
I don't think this case is needed on Hyper-V platform
There was a problem hiding this comment.
It doesn't actually hurt running this on Hyper-V. Fixed it anyway as you suggested.
LiliDeng
reviewed
Feb 4, 2025
LiliDeng
reviewed
Feb 4, 2025
squirrelsc
reviewed
Feb 4, 2025
| @@ -32,7 +32,9 @@ | |||
| It is responsible for ensuring the Hyper V drivers are all present, | |||
| are included in initrd, and are all the same version. | |||
| """, | |||
| requirement=simple_requirement(supported_platform_type=["azure", "ready"]), | |||
| requirement=simple_requirement( | |||
| supported_platform_type=["azure", "ready", "hyperv"] | |||
|
@LiliDeng please let me know if anything more is needed on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will enable more tests to run on Hyper-v platform.